fix: the overlaid sidebar steps aside for a drag, and the compact view follows the trigger
Two reports, both real, and neither was about the lock itself.
**A drag out of an overlaid sidebar had nowhere to land.** In a window too narrow to show both columns,
`AdwOverlaySplitView` puts the sidebar *on* the plot — that is what `collapsed` means — so the pointer
stays over the list and never over a drop target: a signal could be dragged but not dropped, which reads
as "dragging does not work". `row_drag_sidebar()` now hides the sidebar on `drag-begin` and restores it on
`drag-end`, and only when collapsed: side by side the plot is already visible, and hiding the list the drag
started in would be startling. The reading begins a drag through the *source* with the state forced
collapsed, the way the sidebar probe forces it:
pane drag: sidebar hidden for the drag=1 restored after it=1
**The compact view did not follow the trigger switch.** The locked line's first branch reads
`tc.enabled` — with trigger mode off it says `stream (trigger off)` and nothing else — and
`on_trigger_toggled()` never re-synced it, so the line kept saying whichever it had been. One call to
`sync_trigger_summary()` beside the switch sync. The dump's two `panes:` lines were already the test and
now pass it: with a session whose trigger is off, the line as found reads `stream (trigger off)` and the
live one reads the settings, because the exit probe turns the trigger on in between. Both reading `stream`
was the defect.
Verified: the two lines above; `panes: the same line as the probe found it: 'mode: stream (trigger off)'`
against the live `'signal: square | condition: window, rising | level: 0.3 .. 0.6 | mode: normal'`;
`make test-ui` 14 files; zero `Gtk-CRITICAL`. Docs: the `pane drag:` reading and the invariants bullet for
the overlay, and the `panes:` pair's second job — the refresh test — written down so the next reader knows
what both lines reading `stream` means.
This commit is contained in:
1 parent
a43d3830f0
commit
8b2dae7655
8 files changed
+96
-4
No files matched your search
+3
-1
@@ -413,8 +413,10 @@ void on_trigger_toggled(GtkToggleButton* button, gpointer user) {
|
||||
// Arming is a *runtime* control: with trigger mode off there is no engine to arm, and the button is the
|
||||
// one part of this pane that is not a setting. (The body itself stays live -- see above.)
|
||||
if (app->arm_button != nullptr) gtk_widget_set_sensitive(app->arm_button, on);
|
||||
// The pane's own switch shows the same state, whichever of the two was clicked.
|
||||
// The pane's own switch shows the same state, whichever of the two was clicked, and the compact line
|
||||
// changes shape with it: with trigger mode off it says "stream" and nothing else.
|
||||
sync_panel_switches(*app);
|
||||
sync_trigger_summary(*app);
|
||||
}
|
||||
|
||||
/// The way out of trigger mode, from inside the panel that froze the view: it is
|
||||
|
||||
Reference in new issue
Block a user