ui: one way to open the events page, and stale wording after the pane's removal

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Martino FerrariandClaude Sonnet 4.6 committed 2026-11-03 07:11:34 +01:00
1 parent 8c866300d8
commit 794df9b4d0
5 files changed
+40 -30

No files matched your search

+10 -9
View File
@@ -5674,7 +5674,7 @@ gboolean events_probe_step(gpointer user) {
gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(a->trigger_toggle), TRUE);
}
report_events_availability(*a, "after trigger on");
slideover_open(*a, "events");
open_events_page(*a);
// Read straight after the open, before anything else can call the availability rule.
report_events_availability(*a, "after events page opened");
// ... and again a few frames later, still with no replay in the way: this is the *open alone*
@@ -5747,11 +5747,15 @@ gboolean events_probe_step(gpointer user) {
r.stem.c_str(), r.duration_s, r.pre_s, r.post_s, r.edge, r.signals, r.samples,
r.rate_hz, static_cast<unsigned long long>(r.seq), thumb_bytes,
a->event_recording ? 1 : 0, slideover_page(*a) == "events" ? 1 : 0);
// The first latch must not have moved the plot: the list is a slide-over page over the plot's
// edge, and the dock is a fixed column, so nothing about an event changes the plot's width.
}
// The first latch must not have moved the plot: the list is a slide-over page over the plot's
// edge, and the dock is a fixed column, so nothing about an event changes the plot's width. Both
// widths must be real (> 0): two unrealised -1s are equal and would read as stable.
{
const int plot_w_now = a->area_widget != nullptr ? gtk_widget_get_width(a->area_widget) : -1;
std::fprintf(stderr, " plot_w_stable=%d plot_w=%d/%d", plot_w_now == a->dbg_events_plot_w ? 1 : 0,
a->dbg_events_plot_w, plot_w_now);
std::fprintf(stderr, " plot_w_stable=%d plot_w=%d/%d",
(plot_w_now > 0 && plot_w_now == a->dbg_events_plot_w) ? 1 : 0, a->dbg_events_plot_w,
plot_w_now);
}
std::fprintf(stderr, "\n");
std::fflush(stderr);
@@ -5898,10 +5902,7 @@ gboolean events_group_probe_step(gpointer user) {
a->dbg_events_wait = 0;
// Open the page first: its list is only rebuilt while the page is *open* (or by the Manage button), so
// a selection made against a closed page selects rows that are not current.
if (slideover_page(*a) != "events") {
refresh_events_pane(*a);
slideover_open(*a, "events");
}
open_events_page(*a);
// The selection *is* the input, so select the two newest rows the way a user does and press the
// button: `on_group_clicked()` reads the list, not a parameter.
GtkListBox* list = GTK_LIST_BOX(a->events_list);