From 6fe1b2252411d2d74fd87561c0969be77f8c7ffe Mon Sep 17 00:00:00 2001
From: Martino Ferrari <martinogiordano.ferrari@iter.org>
Date: Wed, 14 Oct 2026 17:06:06 +0200
Subject: [PATCH] chore: drop the dead help window's .ui with the window it
 built

`help_window.cpp`'s paged window went with the manual (c1460a6), leaving `src/ui/help.ui` a builder
file that nothing loads and nothing references: its only mention was the bundle manifest beside the
icons. Removed both. That is also the reading `test-ui` now reports -- 13 files, 13 ok -- and no
document stated the old count, so nothing else had to move.

Verified on the integrated tree: clean build --clean-first, 0 errors and exactly the three documented
warnings (the two MathNode missing-initializers and the icons' 12352-byte overlength string); test-ui
13 ok, 0 failed; test-help renders all 15 pages; and two headless probe runs report 0 Gtk-CRITICAL:

    [help] topics=14 index=1 figures=3 ... shortcuts: app=14 plot=14 tables=28 ui=28 ui_accel=21
           ui_icon=7 ui_bare=0 ... closed ok
    [helpui] auto_started=1 visible=1 steps=5 step=0 (tour_seen already set)
    [helpui] contextual on: hints=8 ids={events plot status cursors measures trigger signals window}
    [helpui] main view: rows=7 help_row=1

and the trigger pane's compact Arm/Disarm -- the feature from 620473a -- still reads
`visible=1 sensitive=1 width=51 label=Disarm` with `panel_width=-1` while the pane is locked.
---
 src/ui/help.ui                   | 93 --------------------------------
 src/ui/udpscope-ui.gresource.xml |  1 -
 2 files changed, 94 deletions(-)
 delete mode 100644 src/ui/help.ui

diff --git a/src/ui/help.ui b/src/ui/help.ui
deleted file mode 100644
index e7a1fae..0000000
--- a/src/ui/help.ui
+++ /dev/null
@@ -1,93 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!-- SPDX-License-Identifier: MIT -->
-<!-- SPDX-FileCopyrightText: 2026 Martino Ferrari -->
-<!--
-  The help window's chrome: a window, its own header bar, and a two-pane split whose sidebar is the
-  list of pages and whose content is one page at a time.
-
-  The split is AdwNavigationSplitView rather than a GtkBox with a separator in it, so the sidebar
-  collapses on a narrow window and comes back behind the header bar's button instead of squeezing the
-  text. On a wide one it is the same two panes it always was.
-
-  The page list itself is *not* here: its rows are the fourteen pages in `help_window.cpp`, each with
-  section headings between the groups, and a template cannot know them. What is here is the shape they
-  are put into: an id to find the list by, the scroller around the page, and the label that holds one
-  page's markup with the screenshot column above it.
--->
-<interface>
-  <object class="AdwWindow" id="help_window">
-    <property name="title" translatable="yes">udpscope help</property>
-    <property name="default-width">860</property>
-    <property name="default-height">640</property>
-    <property name="content">
-      <object class="AdwToolbarView">
-        <child type="top">
-          <object class="AdwHeaderBar">
-            <property name="show-title">1</property>
-          </object>
-        </child>
-        <property name="content">
-          <object class="AdwNavigationSplitView">
-            <property name="sidebar">
-              <object class="AdwNavigationPage">
-                <property name="title" translatable="yes">Pages</property>
-                <property name="child">
-                  <object class="GtkScrolledWindow">
-                    <property name="hscrollbar-policy">never</property>
-                    <property name="vscrollbar-policy">automatic</property>
-                    <property name="width-request">220</property>
-                    <property name="child">
-                      <object class="GtkListBox" id="page_list">
-                        <property name="selection-mode">single</property>
-                      </object>
-                    </property>
-                  </object>
-                </property>
-              </object>
-            </property>
-            <property name="content">
-              <object class="AdwNavigationPage">
-                <property name="title" translatable="yes">Page</property>
-                <property name="child">
-                  <object class="GtkScrolledWindow">
-                    <property name="hscrollbar-policy">never</property>
-                    <property name="vscrollbar-policy">automatic</property>
-                    <property name="hexpand">1</property>
-                    <property name="child">
-                      <object class="GtkBox" id="page_box">
-                        <property name="orientation">vertical</property>
-                        <child>
-                          <object class="GtkBox" id="shot_box">
-                            <property name="orientation">vertical</property>
-                            <property name="spacing">8</property>
-                            <property name="margin-start">18</property>
-                            <property name="margin-end">18</property>
-                            <property name="margin-top">14</property>
-                            <property name="visible">0</property>
-                          </object>
-                        </child>
-                        <child>
-                          <object class="GtkLabel" id="body">
-                            <property name="use-markup">1</property>
-                            <property name="wrap">1</property>
-                            <property name="xalign">0</property>
-                            <property name="yalign">0</property>
-                            <property name="selectable">1</property>
-                            <property name="margin-start">18</property>
-                            <property name="margin-end">18</property>
-                            <property name="margin-top">14</property>
-                            <property name="margin-bottom">14</property>
-                          </object>
-                        </child>
-                      </object>
-                    </property>
-                  </object>
-                </property>
-              </object>
-            </property>
-          </object>
-        </property>
-      </object>
-    </property>
-  </object>
-</interface>
diff --git a/src/ui/udpscope-ui.gresource.xml b/src/ui/udpscope-ui.gresource.xml
index c707bc5..3691d4f 100644
--- a/src/ui/udpscope-ui.gresource.xml
+++ b/src/ui/udpscope-ui.gresource.xml
@@ -12,7 +12,6 @@
   <gresource prefix="/org/udpscope/ui">
     <file preprocess="xml-stripblanks">shortcuts.ui</file>
     <file preprocess="xml-stripblanks">preferences.ui</file>
-    <file preprocess="xml-stripblanks">help.ui</file>
     <file preprocess="xml-stripblanks">source-form.ui</file>
     <file preprocess="xml-stripblanks">source-chooser.ui</file>
     <file preprocess="xml-stripblanks">loading.ui</file>