martino/udpscope
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

probe: name the MathNode fields; the build baseline is now one warning

Browse Source 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Martino FerrariandClaude Opus 4.6 committed 2026-11-02 12:06:45 +01:00
1 parent 7b9c62c911
commit 5bb23e6a0a
4 files changed
+18 -21
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/ui_probe.cpp
+7 -8
View File
@@ -467,7 +467,7 @@ gboolean math_probe(gpointer user) {
MathChannel gain;
gain.name = "math x2";
gain.enabled = true;
gain.nodes = {MathNode{MathOp::Source, name}, MathNode{MathOp::Gain}};
gain.nodes = {MathNode{MathOp::Source, name}, MathNode{MathOp::Gain, {}}};
gain.nodes[1].in_a = 0;
gain.nodes[1].gain = 2.0;
gain.output = 1;
@@ -476,14 +476,14 @@ gboolean math_probe(gpointer user) {
MathChannel lp;
lp.name = "math lp";
lp.enabled = true;
lp.nodes = {MathNode{MathOp::Source, late_name}, MathNode{MathOp::LowPass}};
lp.nodes = {MathNode{MathOp::Source, late_name}, MathNode{MathOp::LowPass, {}}};
lp.nodes[1].in_a = 0;
lp.nodes[1].fc = 20.0;
lp.output = 1;
channels.push_back(lp);
// A third channel so the editor's new form row is built and synced on a baseline run. Assigned field
// by field: a partial brace-initialiser would add a fifth build warning.
// by field: a partial brace-initialiser would add a build warning.
MathChannel dn;
dn.name = "math denoise";
dn.enabled = true;
@@ -1269,8 +1269,8 @@ gboolean mathwrap_probe(gpointer user) {
MathChannel gain;
gain.name = "math wrap";
gain.enabled = true;
// Field by field: a partial brace-initialiser would add a fourth build warning, and the baseline
// is exactly three.
// Field by field: a partial brace-initialiser would add a build warning, and the baseline
// is exactly one on a clean build.
MathNode src;
src.op = MathOp::Source;
src.source = name;
@@ -5843,9 +5843,8 @@ int noise_channel(App* a, const char* name) {
// the older feature's proof, so the new channel stays out of the acquisition plan until they have
// all run, and only the de-noise comparison is taken with it in.
//
// Fields assigned rather than brace-initialised: a partial brace-initialiser on `MathNode` is
// what the two `-Wmissing-field-initializers` in this file already are, and the build baseline
// is exactly four warnings.
// Fields assigned rather than brace-initialised: a partial brace-initialiser on `MathNode` leaves
// `source` out and warns (`-Wmissing-field-initializers`), and the build baseline is one warning.
gboolean noise_probe_setup(gpointer user) {
App* a = static_cast<App*>(user);
if (a->window == nullptr) return G_SOURCE_REMOVE;