Compare commits

...

15 Commits

Author SHA1 Message Date
Martino Ferrari
fed39467fd improved doc and tests 2026-01-27 15:19:49 +01:00
Martino Ferrari
15afdc91f4 Improved performances and hover 2026-01-27 15:14:47 +01:00
Martino Ferrari
213fc81cfb Improving LSP 2026-01-27 14:42:46 +01:00
Martino Ferrari
71a3c40108 Better LSP error handling 2026-01-27 08:58:38 +01:00
Martino Ferrari
aedc715ef3 Better code 2026-01-27 00:04:36 +01:00
Martino Ferrari
73cfc43f4b Updated readme. 2026-01-26 23:27:01 +01:00
Martino Ferrari
599beb6f4f updated license 2026-01-26 14:25:47 +01:00
Martino Ferrari
30a105df63 updated readme 2026-01-26 14:24:36 +01:00
Martino Ferrari
04196d8a1f Implement better completion 2026-01-25 15:21:38 +01:00
Martino Ferrari
02274f1bbf Implemented suggestion / autocompletion for signal in GAM 2026-01-25 00:28:50 +01:00
Martino Ferrari
12ed4cfbd2 reverse symbol renaming for signals 2026-01-25 00:18:40 +01:00
Martino Ferrari
bbeb344d19 Improved indexing, hover documentation and implemente renaming 2026-01-25 00:13:07 +01:00
Martino Ferrari
eeb4f5da2e added gam referencing 2026-01-24 23:47:59 +01:00
Martino Ferrari
8e13020d50 better signal hover message 2026-01-24 21:37:08 +01:00
Martino Ferrari
c9cc67f663 Minimal changes 2026-01-24 15:33:23 +01:00
24 changed files with 1859 additions and 128 deletions

View File

@@ -1,6 +1,6 @@
MIT License
Copyright (c) 2026 MARTe Community
Copyright (c) 2026 Martino G. Ferrari <manda.mgf@gmail.com>
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal

View File

@@ -4,11 +4,22 @@
## Features
- **Portability**: A single statically compiled executable compatible with any Linux 3.2+ machine (as well as possible to compile and run on Windows and Mac OS X)
- **LSP Server**: Real-time syntax checking, validation, autocomplete, hover documentation, and navigation (Go to Definition/References).
- **Builder**: Merges multiple configuration files into a single, ordered output file.
- **Formatter**: Standardizes configuration file formatting.
- **Validator**: Advanced semantic validation using [CUE](https://cuelang.org/) schemas, ensuring type safety and structural correctness.
### MARTe extended configuration language
Few additional features have been added to the standard MARTe configuration language:
- Multi file configuration support
- Multi file definition merging
- File level namespace / node
- Doc-strings support
- Pragmas for warning suppression / documentation
## Installation
### From Source
@@ -47,6 +58,7 @@ go install github.com/marte-community/marte-dev-tools/cmd/mdt@latest
## MARTe Configuration
The tools support the MARTe configuration format with extended features:
- **Objects**: `+Node = { Class = ... }`
- **Signals**: `Signal = { Type = ... }`
- **Namespaces**: `#package PROJECT.NODE` for organizing multi-file projects.
@@ -59,11 +71,16 @@ Validation is fully schema-driven using CUE.
- **Custom Schema**: Add a `.marte_schema.cue` file to your project root to extend or override definitions.
**Example `.marte_schema.cue`:**
```cue
package schema
#Classes: {
MyCustomGAM: {
#meta: {
direction: "INOUT"
multithreaded: true
}
Param1: int
Param2?: string
...
@@ -83,14 +100,17 @@ Use comments starting with `//!` to control validation behavior:
## Development
### Building
```bash
go build ./cmd/mdt
```
### Running Tests
```bash
go test ./...
```
## License
MIT

View File

@@ -86,7 +86,6 @@ func runCheck(args []string) {
// Legacy loop removed as ValidateProject covers it via recursion
v.CheckUnused()
for _, diag := range v.Diagnostics {
level := "ERROR"

View File

@@ -5,7 +5,6 @@ import (
"path/filepath"
"strings"
"github.com/marte-community/marte-dev-tools/internal/logger"
"github.com/marte-community/marte-dev-tools/internal/parser"
)
@@ -14,6 +13,7 @@ type ProjectTree struct {
References []Reference
IsolatedFiles map[string]*ProjectNode
GlobalPragmas map[string][]string
NodeMap map[string][]*ProjectNode
}
func (pt *ProjectTree) ScanDirectory(rootPath string) error {
@@ -120,8 +120,11 @@ func (pt *ProjectTree) removeFileFromNode(node *ProjectNode, file string) {
node.Metadata = make(map[string]string)
pt.rebuildMetadata(node)
for _, child := range node.Children {
for name, child := range node.Children {
pt.removeFileFromNode(child, file)
if len(child.Fragments) == 0 && len(child.Children) == 0 {
delete(node.Children, name)
}
}
}
@@ -181,13 +184,8 @@ func (pt *ProjectTree) AddFile(file string, config *parser.Configuration) {
node := pt.Root
parts := strings.Split(config.Package.URI, ".")
// Skip first part as per spec (Project Name is namespace only)
startIdx := 0
if len(parts) > 0 {
startIdx = 1
}
for i := startIdx; i < len(parts); i++ {
for i := 0; i < len(parts); i++ {
part := strings.TrimSpace(parts[i])
if part == "" {
continue
@@ -388,7 +386,19 @@ func (pt *ProjectTree) indexValue(file string, val parser.Value) {
}
}
func (pt *ProjectTree) RebuildIndex() {
pt.NodeMap = make(map[string][]*ProjectNode)
visitor := func(n *ProjectNode) {
pt.NodeMap[n.Name] = append(pt.NodeMap[n.Name], n)
if n.RealName != n.Name {
pt.NodeMap[n.RealName] = append(pt.NodeMap[n.RealName], n)
}
}
pt.Walk(visitor)
}
func (pt *ProjectTree) ResolveReferences() {
pt.RebuildIndex()
for i := range pt.References {
ref := &pt.References[i]
if isoNode, ok := pt.IsolatedFiles[ref.File]; ok {
@@ -400,14 +410,21 @@ func (pt *ProjectTree) ResolveReferences() {
}
func (pt *ProjectTree) FindNode(root *ProjectNode, name string, predicate func(*ProjectNode) bool) *ProjectNode {
if pt.NodeMap == nil {
pt.RebuildIndex()
}
if strings.Contains(name, ".") {
parts := strings.Split(name, ".")
rootName := parts[0]
var candidates []*ProjectNode
pt.findAllNodes(root, rootName, &candidates)
candidates := pt.NodeMap[rootName]
for _, cand := range candidates {
if !pt.isDescendant(cand, root) {
continue
}
curr := cand
valid := true
for i := 1; i < len(parts); i++ {
@@ -429,26 +446,33 @@ func (pt *ProjectTree) FindNode(root *ProjectNode, name string, predicate func(*
return nil
}
if root.RealName == name || root.Name == name {
if predicate == nil || predicate(root) {
return root
candidates := pt.NodeMap[name]
for _, cand := range candidates {
if !pt.isDescendant(cand, root) {
continue
}
}
for _, child := range root.Children {
if res := pt.FindNode(child, name, predicate); res != nil {
return res
if predicate == nil || predicate(cand) {
return cand
}
}
return nil
}
func (pt *ProjectTree) findAllNodes(root *ProjectNode, name string, results *[]*ProjectNode) {
if root.RealName == name || root.Name == name {
*results = append(*results, root)
func (pt *ProjectTree) isDescendant(node, root *ProjectNode) bool {
if node == root {
return true
}
for _, child := range root.Children {
pt.findAllNodes(child, name, results)
if root == nil {
return true
}
curr := node
for curr != nil {
if curr == root {
return true
}
curr = curr.Parent
}
return false
}
type QueryResult struct {
@@ -458,9 +482,7 @@ type QueryResult struct {
}
func (pt *ProjectTree) Query(file string, line, col int) *QueryResult {
logger.Printf("File: %s:%d:%d", file, line, col)
for i := range pt.References {
logger.Printf("%s", pt.Root.Name)
ref := &pt.References[i]
if ref.File == file {
if line == ref.Position.Line && col >= ref.Position.Column && col < ref.Position.Column+len(ref.Name) {

View File

@@ -20,12 +20,10 @@ import (
"cuelang.org/go/cue"
)
type CompletionParams struct {
TextDocument TextDocumentIdentifier `json:"textDocument"`
Position Position `json:"position"`
Context CompletionContext `json:"context,omitempty"`
Context CompletionContext `json:"context"`
}
type CompletionContext struct {
@@ -51,6 +49,7 @@ var Tree = index.NewProjectTree()
var Documents = make(map[string]string)
var ProjectRoot string
var GlobalSchema *schema.Schema
var Output io.Writer = os.Stdout
type JsonRpcMessage struct {
Jsonrpc string `json:"jsonrpc"`
@@ -93,7 +92,9 @@ type VersionedTextDocumentIdentifier struct {
}
type TextDocumentContentChangeEvent struct {
Text string `json:"text"`
Range *Range `json:"range,omitempty"`
RangeLength int `json:"rangeLength,omitempty"`
Text string `json:"text"`
}
type HoverParams struct {
@@ -161,6 +162,16 @@ type DocumentFormattingParams struct {
Options FormattingOptions `json:"options"`
}
type RenameParams struct {
TextDocument TextDocumentIdentifier `json:"textDocument"`
Position Position `json:"position"`
NewName string `json:"newName"`
}
type WorkspaceEdit struct {
Changes map[string][]TextEdit `json:"changes"`
}
type FormattingOptions struct {
TabSize int `json:"tabSize"`
InsertSpaces bool `json:"insertSpaces"`
@@ -171,7 +182,6 @@ type TextEdit struct {
NewText string `json:"newText"`
}
func RunServer() {
reader := bufio.NewReader(os.Stdin)
for {
@@ -215,6 +225,12 @@ func readMessage(reader *bufio.Reader) (*JsonRpcMessage, error) {
}
func HandleMessage(msg *JsonRpcMessage) {
defer func() {
if r := recover(); r != nil {
logger.Printf("Panic in HandleMessage: %v", r)
}
}()
switch msg.Method {
case "initialize":
var params InitializeParams
@@ -239,11 +255,12 @@ func HandleMessage(msg *JsonRpcMessage) {
respond(msg.ID, map[string]any{
"capabilities": map[string]any{
"textDocumentSync": 1, // Full sync
"textDocumentSync": 2, // Incremental sync
"hoverProvider": true,
"definitionProvider": true,
"referencesProvider": true,
"documentFormattingProvider": true,
"renameProvider": true,
"completionProvider": map[string]any{
"triggerCharacters": []string{"=", " "},
},
@@ -300,6 +317,11 @@ func HandleMessage(msg *JsonRpcMessage) {
if err := json.Unmarshal(msg.Params, &params); err == nil {
respond(msg.ID, HandleFormatting(params))
}
case "textDocument/rename":
var params RenameParams
if err := json.Unmarshal(msg.Params, &params); err == nil {
respond(msg.ID, HandleRename(params))
}
}
}
@@ -327,28 +349,76 @@ func HandleDidOpen(params DidOpenTextDocumentParams) {
}
func HandleDidChange(params DidChangeTextDocumentParams) {
if len(params.ContentChanges) == 0 {
return
uri := params.TextDocument.URI
text, ok := Documents[uri]
if !ok {
// If not found, rely on full sync being first or error
}
text := params.ContentChanges[0].Text
Documents[params.TextDocument.URI] = text
path := uriToPath(params.TextDocument.URI)
for _, change := range params.ContentChanges {
if change.Range == nil {
text = change.Text
} else {
text = applyContentChange(text, change)
}
}
Documents[uri] = text
path := uriToPath(uri)
p := parser.NewParser(text)
config, err := p.Parse()
if err != nil {
publishParserError(params.TextDocument.URI, err)
publishParserError(uri, err)
} else {
publishParserError(params.TextDocument.URI, nil)
publishParserError(uri, nil)
}
if config != nil {
Tree.AddFile(path, config)
Tree.ResolveReferences()
runValidation(params.TextDocument.URI)
runValidation(uri)
}
}
func applyContentChange(text string, change TextDocumentContentChangeEvent) string {
startOffset := offsetAt(text, change.Range.Start)
endOffset := offsetAt(text, change.Range.End)
if startOffset == -1 || endOffset == -1 {
return text
}
return text[:startOffset] + change.Text + text[endOffset:]
}
func offsetAt(text string, pos Position) int {
line := 0
col := 0
for i, r := range text {
if line == pos.Line && col == pos.Character {
return i
}
if line > pos.Line {
break
}
if r == '\n' {
line++
col = 0
} else {
if r >= 0x10000 {
col += 2
} else {
col++
}
}
}
if line == pos.Line && col == pos.Character {
return len(text)
}
return -1
}
func HandleFormatting(params DocumentFormattingParams) []TextEdit {
uri := params.TextDocument.URI
text, ok := Documents[uri]
@@ -382,10 +452,9 @@ func HandleFormatting(params DocumentFormattingParams) []TextEdit {
}
}
func runValidation(uri string) {
func runValidation(_ string) {
v := validator.NewValidator(Tree, ProjectRoot)
v.ValidateProject()
v.CheckUnused()
// Group diagnostics by file
fileDiags := make(map[string][]LSPDiagnostic)
@@ -567,10 +636,7 @@ func HandleCompletion(params CompletionParams) *CompletionList {
}
lineStr := lines[params.Position.Line]
col := params.Position.Character
if col > len(lineStr) {
col = len(lineStr)
}
col := min(params.Position.Character, len(lineStr))
prefix := lineStr[:col]
@@ -601,12 +667,88 @@ func HandleCompletion(params CompletionParams) *CompletionList {
// Case 2: Typing a key inside an object
container := Tree.GetNodeContaining(path, parser.Position{Line: params.Position.Line + 1, Column: col + 1})
if container != nil {
if container.Parent != nil && isGAM(container.Parent) {
if container.Name == "InputSignals" {
return suggestGAMSignals(container, "Input")
}
if container.Name == "OutputSignals" {
return suggestGAMSignals(container, "Output")
}
}
return suggestFields(container)
}
return nil
}
func suggestGAMSignals(_ *index.ProjectNode, direction string) *CompletionList {
var items []CompletionItem
processNode := func(node *index.ProjectNode) {
if !isDataSource(node) {
return
}
cls := node.Metadata["Class"]
if cls == "" {
return
}
dir := "NIL"
if GlobalSchema != nil {
classPath := cue.ParsePath(fmt.Sprintf("#Classes.%s.#meta.direction", cls))
val := GlobalSchema.Value.LookupPath(classPath)
if val.Err() == nil {
var s string
if err := val.Decode(&s); err == nil {
dir = s
}
}
}
compatible := false
switch direction {
case "Input":
compatible = dir == "IN" || dir == "INOUT"
case "Output":
compatible = dir == "OUT" || dir == "INOUT"
default:
compatible = false
}
if !compatible {
return
}
signalsContainer := node.Children["Signals"]
if signalsContainer == nil {
return
}
for _, sig := range signalsContainer.Children {
dsName := node.Name
sigName := sig.Name
label := fmt.Sprintf("%s:%s", dsName, sigName)
insertText := fmt.Sprintf("%s = {\n DataSource = %s \n}", sigName, dsName)
items = append(items, CompletionItem{
Label: label,
Kind: 6, // Variable
Detail: "Signal from " + dsName,
InsertText: insertText,
InsertTextFormat: 2, // Snippet
})
}
}
Tree.Walk(processNode)
if len(items) > 0 {
return &CompletionList{Items: items}
}
return nil
}
func suggestClasses() *CompletionList {
if GlobalSchema == nil {
return nil
@@ -784,10 +926,10 @@ func suggestCUEEnums(container *index.ProjectNode, field string) *CompletionList
continue
}
// Ensure strings are quoted
if v.Kind() == cue.StringKind && !strings.HasPrefix(str, "\"") {
str = fmt.Sprintf("\"%s\"", str)
}
// Ensure strings are quoted
if v.Kind() == cue.StringKind && !strings.HasPrefix(str, "\"") {
str = fmt.Sprintf("\"%s\"", str)
}
items = append(items, CompletionItem{
Label: str,
@@ -811,14 +953,11 @@ func suggestObjects(root *index.ProjectNode, filter string) *CompletionList {
var walk func(*index.ProjectNode)
walk = func(node *index.ProjectNode) {
match := false
if filter == "GAM" {
if isGAM(node) {
match = true
}
} else if filter == "DataSource" {
if isDataSource(node) {
match = true
}
switch filter {
case "GAM":
match = isGAM(node)
case "DataSource":
match = isDataSource(node)
}
if match {
@@ -981,6 +1120,14 @@ func formatNodeInfo(node *index.ProjectNode) string {
typ := node.Metadata["Type"]
ds := node.Metadata["DataSource"]
if ds == "" {
if node.Parent != nil && node.Parent.Name == "Signals" {
if node.Parent.Parent != nil {
ds = node.Parent.Parent.Name
}
}
}
if typ != "" || ds != "" {
sigInfo := "\n"
if typ != "" {
@@ -1053,19 +1200,214 @@ func formatNodeInfo(node *index.ProjectNode) string {
}
}
// Find GAM usages
var gams []string
// 1. Check References (explicit text references)
for _, ref := range Tree.References {
if ref.Target == node {
container := Tree.GetNodeContaining(ref.File, ref.Position)
if container != nil {
curr := container
for curr != nil {
if isGAM(curr) {
suffix := ""
p := container
for p != nil && p != curr {
if p.Name == "InputSignals" {
suffix = " (Input)"
break
}
if p.Name == "OutputSignals" {
suffix = " (Output)"
break
}
p = p.Parent
}
gams = append(gams, curr.RealName+suffix)
break
}
curr = curr.Parent
}
}
}
}
// 2. Check Direct Usages (Nodes targeting this node)
Tree.Walk(func(n *index.ProjectNode) {
if n.Target == node {
if n.Parent != nil && (n.Parent.Name == "InputSignals" || n.Parent.Name == "OutputSignals") {
if n.Parent.Parent != nil && isGAM(n.Parent.Parent) {
suffix := " (Input)"
if n.Parent.Name == "OutputSignals" {
suffix = " (Output)"
}
gams = append(gams, n.Parent.Parent.RealName+suffix)
}
}
}
})
if len(gams) > 0 {
uniqueGams := make(map[string]bool)
info += "\n\n**Used in GAMs**:\n"
for _, g := range gams {
if !uniqueGams[g] {
uniqueGams[g] = true
info += fmt.Sprintf("- %s\n", g)
}
}
}
return info
}
func HandleRename(params RenameParams) *WorkspaceEdit {
path := uriToPath(params.TextDocument.URI)
line := params.Position.Line + 1
col := params.Position.Character + 1
res := Tree.Query(path, line, col)
if res == nil {
return nil
}
var targetNode *index.ProjectNode
var targetField *parser.Field
if res.Node != nil {
if res.Node.Target != nil {
targetNode = res.Node.Target
} else {
targetNode = res.Node
}
} else if res.Field != nil {
targetField = res.Field
} else if res.Reference != nil {
if res.Reference.Target != nil {
targetNode = res.Reference.Target
} else {
return nil
}
}
changes := make(map[string][]TextEdit)
addEdit := func(file string, rng Range, newText string) {
uri := "file://" + file
changes[uri] = append(changes[uri], TextEdit{Range: rng, NewText: newText})
}
if targetNode != nil {
// 1. Rename Definitions
prefix := ""
if len(targetNode.RealName) > 0 {
first := targetNode.RealName[0]
if first == '+' || first == '$' {
prefix = string(first)
}
}
normNewName := strings.TrimLeft(params.NewName, "+$")
finalDefName := prefix + normNewName
for _, frag := range targetNode.Fragments {
if frag.IsObject {
rng := Range{
Start: Position{Line: frag.ObjectPos.Line - 1, Character: frag.ObjectPos.Column - 1},
End: Position{Line: frag.ObjectPos.Line - 1, Character: frag.ObjectPos.Column - 1 + len(targetNode.RealName)},
}
addEdit(frag.File, rng, finalDefName)
}
}
// 2. Rename References
for _, ref := range Tree.References {
if ref.Target == targetNode {
// Handle qualified names (e.g. Pkg.Node)
if strings.Contains(ref.Name, ".") {
if strings.HasSuffix(ref.Name, "."+targetNode.Name) {
prefixLen := len(ref.Name) - len(targetNode.Name)
rng := Range{
Start: Position{Line: ref.Position.Line - 1, Character: ref.Position.Column - 1 + prefixLen},
End: Position{Line: ref.Position.Line - 1, Character: ref.Position.Column - 1 + len(ref.Name)},
}
addEdit(ref.File, rng, normNewName)
} else if ref.Name == targetNode.Name {
rng := Range{
Start: Position{Line: ref.Position.Line - 1, Character: ref.Position.Column - 1},
End: Position{Line: ref.Position.Line - 1, Character: ref.Position.Column - 1 + len(ref.Name)},
}
addEdit(ref.File, rng, normNewName)
}
} else {
rng := Range{
Start: Position{Line: ref.Position.Line - 1, Character: ref.Position.Column - 1},
End: Position{Line: ref.Position.Line - 1, Character: ref.Position.Column - 1 + len(ref.Name)},
}
addEdit(ref.File, rng, normNewName)
}
}
}
// 3. Rename Implicit Node References (Signals in GAMs relying on name match)
Tree.Walk(func(n *index.ProjectNode) {
if n.Target == targetNode {
hasAlias := false
for _, frag := range n.Fragments {
for _, def := range frag.Definitions {
if f, ok := def.(*parser.Field); ok && f.Name == "Alias" {
hasAlias = true
}
}
}
if !hasAlias {
for _, frag := range n.Fragments {
if frag.IsObject {
rng := Range{
Start: Position{Line: frag.ObjectPos.Line - 1, Character: frag.ObjectPos.Column - 1},
End: Position{Line: frag.ObjectPos.Line - 1, Character: frag.ObjectPos.Column - 1 + len(n.RealName)},
}
addEdit(frag.File, rng, normNewName)
}
}
}
}
})
return &WorkspaceEdit{Changes: changes}
} else if targetField != nil {
container := Tree.GetNodeContaining(path, targetField.Position)
if container != nil {
for _, frag := range container.Fragments {
for _, def := range frag.Definitions {
if f, ok := def.(*parser.Field); ok {
if f.Name == targetField.Name {
rng := Range{
Start: Position{Line: f.Position.Line - 1, Character: f.Position.Column - 1},
End: Position{Line: f.Position.Line - 1, Character: f.Position.Column - 1 + len(f.Name)},
}
addEdit(frag.File, rng, params.NewName)
}
}
}
}
}
return &WorkspaceEdit{Changes: changes}
}
return nil
}
func respond(id any, result any) {
msg := JsonRpcMessage{
Jsonrpc: "2.0",
ID: id,
Result: result,
msg := map[string]any{
"jsonrpc": "2.0",
"id": id,
"result": result,
}
send(msg)
}
func send(msg any) {
body, _ := json.Marshal(msg)
fmt.Printf("Content-Length: %d\r\n\r\n%s", len(body), body)
fmt.Fprintf(Output, "Content-Length: %d\r\n\r\n%s", len(body), body)
}

View File

@@ -129,7 +129,7 @@ func (l *Lexer) NextToken() Token {
case '/':
return l.lexComment()
case '#':
return l.lexPackage()
return l.lexHashIdentifier()
case '+':
fallthrough
case '$':
@@ -243,18 +243,19 @@ func (l *Lexer) lexUntilNewline(t TokenType) Token {
}
}
func (l *Lexer) lexPackage() Token {
func (l *Lexer) lexHashIdentifier() Token {
// We are at '#', l.start is just before it
for {
r := l.next()
if unicode.IsLetter(r) {
if unicode.IsLetter(r) || unicode.IsDigit(r) || r == '_' || r == '-' || r == '.' || r == ':' || r == '#' {
continue
}
l.backup()
break
}
if l.input[l.start:l.pos] == "#package" {
val := l.input[l.start:l.pos]
if val == "#package" {
return l.lexUntilNewline(TokenPackage)
}
return l.emit(TokenError)
return l.emit(TokenIdentifier)
}

View File

@@ -13,7 +13,7 @@ package schema
StateMachineEvent: {
NextState!: string
NextStateError!: string
Timeout: uint32
Timeout?: uint32
[_= !~"^(Class|NextState|Timeout|NextStateError|[#_$].+)$"]: Message
...
}
@@ -43,7 +43,8 @@ package schema
...
}
TimingDataSource: {
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
IOGAM: {
@@ -64,73 +65,86 @@ package schema
...
}
FileDataSource: {
Filename: string
Format?: string
direction: "INOUT"
Filename: string
Format?: string
#meta: multithreaded: bool | *false
#meta: direction: "INOUT"
...
}
LoggerDataSource: {
direction: "OUT"
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
DANStream: {
Timeout?: int
direction: "OUT"
Timeout?: int
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
EPICSCAInput: {
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
EPICSCAOutput: {
direction: "OUT"
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
EPICSPVAInput: {
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
EPICSPVAOutput: {
direction: "OUT"
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
SDNSubscriber: {
Address: string
Port: int
Interface?: string
direction: "IN"
Address: string
Port: int
Interface?: string
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
SDNPublisher: {
Address: string
Port: int
Interface?: string
direction: "OUT"
Address: string
Port: int
Interface?: string
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
UDPReceiver: {
Port: int
Address?: string
direction: "IN"
Port: int
Address?: string
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
UDPSender: {
Destination: string
direction: "OUT"
Destination: string
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
FileReader: {
Filename: string
Format?: string
Interpolate?: string
direction: "IN"
Filename: string
Format?: string
Interpolate?: string
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
FileWriter: {
Filename: string
Format?: string
StoreOnTrigger?: int
direction: "OUT"
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
OrderedClass: {
@@ -173,7 +187,8 @@ package schema
TriggeredIOGAM: {...}
WaveformGAM: {...}
DAN: {
direction: "OUT"
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
LinuxTimer: {
@@ -184,11 +199,13 @@ package schema
CPUMask?: int
TimeProvider?: {...}
Signals: {...}
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
LinkDataSource: {
direction: "INOUT"
#meta: multithreaded: bool | *false
#meta: direction: "INOUT"
...
}
MDSReader: {
@@ -196,7 +213,8 @@ package schema
ShotNumber: int
Frequency: float | int
Signals: {...}
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
MDSWriter: {
@@ -212,57 +230,74 @@ package schema
NumberOfPostTriggers?: int
Signals: {...}
Messages?: {...}
direction: "OUT"
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
NI1588TimeStamp: {
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
NI6259ADC: {
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
NI6259DAC: {
direction: "OUT"
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
NI6259DIO: {
direction: "INOUT"
#meta: multithreaded: bool | *false
#meta: direction: "INOUT"
...
}
NI6368ADC: {
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
NI6368DAC: {
direction: "OUT"
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
NI6368DIO: {
direction: "INOUT"
#meta: multithreaded: bool | *false
#meta: direction: "INOUT"
...
}
NI9157CircularFifoReader: {
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
NI9157MxiDataSource: {
direction: "INOUT"
#meta: multithreaded: bool | *false
#meta: direction: "INOUT"
...
}
OPCUADSInput: {
direction: "IN"
#meta: multithreaded: bool | *false
#meta: direction: "IN"
...
}
OPCUADSOutput: {
direction: "OUT"
#meta: multithreaded: bool | *false
#meta: direction: "OUT"
...
}
RealTimeThreadAsyncBridge: {
#meta: direction: "INOUT"
#meta: multithreaded: bool | true
...
}
RealTimeThreadAsyncBridge: {...}
RealTimeThreadSynchronisation: {...}
UARTDataSource: {
direction: "INOUT"
#meta: multithreaded: bool | *false
#meta: direction: "INOUT"
...
}
BaseLib2Wrapper: {...}
@@ -272,7 +307,8 @@ package schema
OPCUA: {...}
SysLogger: {...}
GAMDataSource: {
direction: "INOUT"
#meta: multithreaded: bool | *false
#meta: direction: "INOUT"
...
}
}

View File

@@ -53,6 +53,8 @@ func (v *Validator) ValidateProject() {
for _, node := range v.Tree.IsolatedFiles {
v.validateNode(node)
}
v.CheckUnused()
v.CheckDataSourceThreading()
}
func (v *Validator) validateNode(node *index.ProjectNode) {
@@ -313,8 +315,8 @@ func (v *Validator) validateGAMSignal(gamNode, signalNode *index.ProjectNode, di
dsClass := v.getNodeClass(dsNode)
if dsClass != "" {
// Lookup class definition in Schema
// path: #Classes.ClassName.direction
path := cue.ParsePath(fmt.Sprintf("#Classes.%s.direction", dsClass))
// path: #Classes.ClassName.#meta.direction
path := cue.ParsePath(fmt.Sprintf("#Classes.%s.#meta.direction", dsClass))
val := v.Schema.Value.LookupPath(path)
if val.Err() == nil {
@@ -509,6 +511,8 @@ func (v *Validator) getFieldValue(f *parser.Field) string {
return val.Raw
case *parser.FloatValue:
return val.Raw
case *parser.BoolValue:
return strconv.FormatBool(val.Value)
}
return ""
}
@@ -542,11 +546,6 @@ func isValidType(t string) bool {
return false
}
func (v *Validator) checkType(val parser.Value, expectedType string) bool {
// Legacy function, replaced by CUE.
return true
}
func (v *Validator) getFileForField(f *parser.Field, node *index.ProjectNode) string {
for _, frag := range node.Fragments {
for _, def := range frag.Definitions {
@@ -746,3 +745,142 @@ func (v *Validator) isGloballyAllowed(warningType string, contextFile string) bo
}
return false
}
func (v *Validator) CheckDataSourceThreading() {
if v.Tree.Root == nil {
return
}
// 1. Find RealTimeApplication
var appNode *index.ProjectNode
findApp := func(n *index.ProjectNode) {
if cls, ok := n.Metadata["Class"]; ok && cls == "RealTimeApplication" {
appNode = n
}
}
v.Tree.Walk(findApp)
if appNode == nil {
return
}
// 2. Find States
var statesNode *index.ProjectNode
if s, ok := appNode.Children["States"]; ok {
statesNode = s
} else {
for _, child := range appNode.Children {
if cls, ok := child.Metadata["Class"]; ok && cls == "StateMachine" {
statesNode = child
break
}
}
}
if statesNode == nil {
return
}
// 3. Iterate States
for _, state := range statesNode.Children {
dsUsage := make(map[*index.ProjectNode]string) // DS Node -> Thread Name
var threads []*index.ProjectNode
// Search for threads in the state (either direct children or inside "Threads" container)
for _, child := range state.Children {
if child.RealName == "Threads" {
for _, t := range child.Children {
if cls, ok := t.Metadata["Class"]; ok && cls == "RealTimeThread" {
threads = append(threads, t)
}
}
} else {
if cls, ok := child.Metadata["Class"]; ok && cls == "RealTimeThread" {
threads = append(threads, child)
}
}
}
for _, thread := range threads {
gams := v.getThreadGAMs(thread)
for _, gam := range gams {
dss := v.getGAMDataSources(gam)
for _, ds := range dss {
if existingThread, ok := dsUsage[ds]; ok {
if existingThread != thread.RealName {
if !v.isMultithreaded(ds) {
v.Diagnostics = append(v.Diagnostics, Diagnostic{
Level: LevelError,
Message: fmt.Sprintf("DataSource '%s' is not multithreaded but used in multiple threads (%s, %s) in state '%s'", ds.RealName, existingThread, thread.RealName, state.RealName),
Position: v.getNodePosition(gam),
File: v.getNodeFile(gam),
})
}
}
} else {
dsUsage[ds] = thread.RealName
}
}
}
}
}
}
func (v *Validator) getThreadGAMs(thread *index.ProjectNode) []*index.ProjectNode {
var gams []*index.ProjectNode
fields := v.getFields(thread)
if funcs, ok := fields["Functions"]; ok && len(funcs) > 0 {
f := funcs[0]
if arr, ok := f.Value.(*parser.ArrayValue); ok {
for _, elem := range arr.Elements {
if ref, ok := elem.(*parser.ReferenceValue); ok {
target := v.resolveReference(ref.Value, v.getNodeFile(thread), isGAM)
if target != nil {
gams = append(gams, target)
}
}
}
}
}
return gams
}
func (v *Validator) getGAMDataSources(gam *index.ProjectNode) []*index.ProjectNode {
dsMap := make(map[*index.ProjectNode]bool)
processSignals := func(container *index.ProjectNode) {
if container == nil {
return
}
for _, sig := range container.Children {
fields := v.getFields(sig)
if dsFields, ok := fields["DataSource"]; ok && len(dsFields) > 0 {
dsName := v.getFieldValue(dsFields[0])
dsNode := v.resolveReference(dsName, v.getNodeFile(sig), isDataSource)
if dsNode != nil {
dsMap[dsNode] = true
}
}
}
}
processSignals(gam.Children["InputSignals"])
processSignals(gam.Children["OutputSignals"])
var dss []*index.ProjectNode
for ds := range dsMap {
dss = append(dss, ds)
}
return dss
}
func (v *Validator) isMultithreaded(ds *index.ProjectNode) bool {
if meta, ok := ds.Children["#meta"]; ok {
fields := v.getFields(meta)
if mt, ok := fields["multithreaded"]; ok && len(mt) > 0 {
val := v.getFieldValue(mt[0])
return val == "true"
}
}
return false
}

View File

@@ -21,11 +21,12 @@ The executable should support the following subcommands:
The LSP server should provide the following capabilities:
- **Diagnostics**: Report syntax errors and validation issues.
- **Incremental Sync**: Supports `textDocumentSync` kind 2 (Incremental) for better performance with large files.
- **Hover Documentation**:
- **Objects**: Display `CLASS::Name` and any associated docstrings.
- **Signals**: Display `DataSource.Name TYPE (SIZE) [IN/OUT/INOUT]` along with docstrings.
- **GAMs**: Show the list of States where the GAM is referenced.
- **Referenced Signals**: Show the list of GAMs where the signal is referenced.
- **Referenced Signals**: Show the list of GAMs where the signal is referenced (indicating Input/Output direction).
- **Go to Definition**: Jump to the definition of a reference, supporting navigation across any file in the current project.
- **Go to References**: Find usages of a node or field, supporting navigation across any file in the current project.
- **Code Completion**: Autocomplete fields, values, and references.
@@ -34,6 +35,13 @@ The LSP server should provide the following capabilities:
- **Reference Suggestions**:
- `DataSource` fields suggest available DataSource objects.
- `Functions` (in Threads) suggest available GAM objects.
- **Signal Completion**: Inside `InputSignals` or `OutputSignals` of a GAM:
- Suggests available signals from valid DataSources (filtering by direction: `IN`/`INOUT` for Inputs, `OUT`/`INOUT` for Outputs).
- Format: `SIGNAL_NAME:DATASOURCE_NAME`.
- Auto-inserts: `SIGNAL_NAME = { DataSource = DATASOURCE_NAME }`.
- **Rename Symbol**: Rename an object, field, or reference across the entire project scope.
- Supports renaming of Definitions (`+Name` or `Name`), preserving any modifiers (`+`/`$`).
- Updates all references to the renamed symbol, including qualified references (e.g., `Pkg.Name`).
- **Code Snippets**: Provide snippets for common patterns (e.g., `+Object = { ... }`).
- **Formatting**: Format the document using the same rules and engine as the `fmt` command.
@@ -166,6 +174,7 @@ The tool must build an index of the configuration to support LSP features and va
- **Conditional Fields**: Validation of fields whose presence or value depends on the values of other fields within the same node or context.
- **Schema Definition**:
- Class validation rules must be defined in a separate schema file using the **CUE** language.
- **Metadata**: Class properties like direction (`#direction`) and multithreading support (`#multithreaded`) are stored within a `#meta` field in the class definition (e.g., `#meta: { direction: "IN", multithreaded: true }`).
- **Project-Specific Classes**: Developers can define their own project-specific classes and corresponding validation rules, expanding the validation capabilities for their specific needs.
- **Schema Loading**:
- **Default Schema**: The tool should look for a default schema file `marte_schema.cue` in standard system locations:
@@ -211,6 +220,7 @@ The LSP and `check` command should report the following:
- Field type mismatches.
- Grammar errors (e.g., missing closing brackets).
- **Invalid Function Reference**: Elements in the `Functions` array of a `State.Thread` must be valid references to defined GAM nodes.
- **Threading Violation**: A DataSource that is not marked as multithreaded (via `#meta.multithreaded`) is used by GAMs running in different threads within the same State.
## Logging

94
test/ast_test.go Normal file
View File

@@ -0,0 +1,94 @@
package integration
import (
"testing"
"github.com/marte-community/marte-dev-tools/internal/parser"
)
func TestASTCoverage(t *testing.T) {
pos := parser.Position{Line: 1, Column: 1}
var n parser.Node
// var d parser.Definition // Definition has unexported method, can't assign?
// Yes I can assign if I am using the interface type exported by parser.
// But I cannot call the method.
var d parser.Definition
var v parser.Value
// Field
f := &parser.Field{Position: pos}
n = f
d = f
if n.Pos() != pos {
t.Error("Field.Pos failed")
}
_ = d
// ObjectNode
o := &parser.ObjectNode{Position: pos}
n = o
d = o
if n.Pos() != pos {
t.Error("ObjectNode.Pos failed")
}
// StringValue
sv := &parser.StringValue{Position: pos}
n = sv
v = sv
if n.Pos() != pos {
t.Error("StringValue.Pos failed")
}
_ = v
// IntValue
iv := &parser.IntValue{Position: pos}
n = iv
v = iv
if n.Pos() != pos {
t.Error("IntValue.Pos failed")
}
// FloatValue
fv := &parser.FloatValue{Position: pos}
n = fv
v = fv
if n.Pos() != pos {
t.Error("FloatValue.Pos failed")
}
// BoolValue
bv := &parser.BoolValue{Position: pos}
n = bv
v = bv
if n.Pos() != pos {
t.Error("BoolValue.Pos failed")
}
// ReferenceValue
rv := &parser.ReferenceValue{Position: pos}
n = rv
v = rv
if n.Pos() != pos {
t.Error("ReferenceValue.Pos failed")
}
// ArrayValue
av := &parser.ArrayValue{Position: pos}
n = av
v = av
if n.Pos() != pos {
t.Error("ArrayValue.Pos failed")
}
// Package
pkg := &parser.Package{Position: pos}
// Package implements Node?
// ast.go: func (p *Package) Pos() Position { return p.Position }
// Yes.
n = pkg
if n.Pos() != pos {
t.Error("Package.Pos failed")
}
}

View File

@@ -0,0 +1,58 @@
package integration
import (
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/parser"
)
func TestIndexCleanup(t *testing.T) {
idx := index.NewProjectTree()
file := "cleanup.marte"
content := `
#package Pkg
+Node = { Class = Type }
`
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatal(err)
}
idx.AddFile(file, cfg)
// Check node exists
// Root -> Pkg -> Node
pkgNode := idx.Root.Children["Pkg"]
if pkgNode == nil {
t.Fatal("Pkg node should exist")
}
if pkgNode.Children["Node"] == nil {
t.Fatal("Node should exist")
}
// Update file: remove +Node
content2 := `
#package Pkg
// Removed node
`
p2 := parser.NewParser(content2)
cfg2, _ := p2.Parse()
idx.AddFile(file, cfg2)
// Check Node is gone
pkgNode = idx.Root.Children["Pkg"]
if pkgNode == nil {
// Pkg should exist because of #package Pkg
t.Fatal("Pkg node should exist after update")
}
if pkgNode.Children["Node"] != nil {
t.Error("Node should be gone")
}
// Test removing file completely
idx.RemoveFile(file)
if len(idx.Root.Children) != 0 {
t.Errorf("Root should be empty after removing file, got %d children", len(idx.Root.Children))
}
}

66
test/index_test.go Normal file
View File

@@ -0,0 +1,66 @@
package integration
import (
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
)
func TestNodeMap(t *testing.T) {
pt := index.NewProjectTree()
root := pt.Root
// Create structure: +A -> +B -> +C
nodeA := &index.ProjectNode{Name: "A", RealName: "+A", Children: make(map[string]*index.ProjectNode), Parent: root}
root.Children["A"] = nodeA
nodeB := &index.ProjectNode{Name: "B", RealName: "+B", Children: make(map[string]*index.ProjectNode), Parent: nodeA}
nodeA.Children["B"] = nodeB
nodeC := &index.ProjectNode{Name: "C", RealName: "+C", Children: make(map[string]*index.ProjectNode), Parent: nodeB}
nodeB.Children["C"] = nodeC
// Rebuild Index
pt.RebuildIndex()
// Find by Name
found := pt.FindNode(root, "C", nil)
if found != nodeC {
t.Errorf("FindNode(C) failed. Got %v, want %v", found, nodeC)
}
// Find by RealName
found = pt.FindNode(root, "+C", nil)
if found != nodeC {
t.Errorf("FindNode(+C) failed. Got %v, want %v", found, nodeC)
}
// Find by Path
found = pt.FindNode(root, "A.B.C", nil)
if found != nodeC {
t.Errorf("FindNode(A.B.C) failed. Got %v, want %v", found, nodeC)
}
// Find by Path with RealName
found = pt.FindNode(root, "+A.+B.+C", nil)
if found != nodeC {
t.Errorf("FindNode(+A.+B.+C) failed. Got %v, want %v", found, nodeC)
}
}
func TestResolveReferencesWithMap(t *testing.T) {
pt := index.NewProjectTree()
root := pt.Root
nodeA := &index.ProjectNode{Name: "A", RealName: "+A", Children: make(map[string]*index.ProjectNode), Parent: root}
root.Children["A"] = nodeA
ref := index.Reference{Name: "A", File: "test.marte"}
pt.References = append(pt.References, ref)
pt.ResolveReferences()
if pt.References[0].Target != nodeA {
t.Error("ResolveReferences failed to resolve A")
}
}

View File

@@ -0,0 +1,90 @@
package integration
import (
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/lsp"
"github.com/marte-community/marte-dev-tools/internal/parser"
"github.com/marte-community/marte-dev-tools/internal/schema"
)
func TestSuggestSignalsRobustness(t *testing.T) {
// Setup
lsp.Tree = index.NewProjectTree()
lsp.Documents = make(map[string]string)
lsp.ProjectRoot = "."
lsp.GlobalSchema = schema.NewSchema()
// Inject schema with INOUT
custom := []byte(`
package schema
#Classes: {
InOutReader: { #meta: direction: "INOUT" }
}
`)
val := lsp.GlobalSchema.Context.CompileBytes(custom)
lsp.GlobalSchema.Value = lsp.GlobalSchema.Value.Unify(val)
content := `
+DS = {
Class = InOutReader
+Signals = {
Sig = { Type = uint32 }
}
}
+GAM = {
Class = IOGAM
+InputSignals = {
}
+OutputSignals = {
}
}
`
uri := "file://robust.marte"
lsp.Documents[uri] = content
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatal(err)
}
lsp.Tree.AddFile("robust.marte", cfg)
// Check Input (Line 10)
paramsIn := lsp.CompletionParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 10, Character: 8},
}
listIn := lsp.HandleCompletion(paramsIn)
found := false
if listIn != nil {
for _, item := range listIn.Items {
if item.Label == "DS:Sig" {
found = true
}
}
}
if !found {
t.Error("INOUT signal not found in InputSignals")
}
// Check Output (Line 13)
paramsOut := lsp.CompletionParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 13, Character: 8},
}
listOut := lsp.HandleCompletion(paramsOut)
found = false
if listOut != nil {
for _, item := range listOut.Items {
if item.Label == "DS:Sig" {
found = true
}
}
}
if !found {
t.Error("INOUT signal not found in OutputSignals")
}
}

View File

@@ -0,0 +1,128 @@
package integration
import (
"strings"
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/lsp"
"github.com/marte-community/marte-dev-tools/internal/parser"
"github.com/marte-community/marte-dev-tools/internal/schema"
)
func TestSuggestSignalsInGAM(t *testing.T) {
// Setup
lsp.Tree = index.NewProjectTree()
lsp.Documents = make(map[string]string)
lsp.ProjectRoot = "."
lsp.GlobalSchema = schema.NewSchema()
// Inject schema for directionality
custom := []byte(`
package schema
#Classes: {
FileReader: { direction: "IN" }
FileWriter: { direction: "OUT" }
}
`)
val := lsp.GlobalSchema.Context.CompileBytes(custom)
lsp.GlobalSchema.Value = lsp.GlobalSchema.Value.Unify(val)
content := `
+InDS = {
Class = FileReader
+Signals = {
InSig = { Type = uint32 }
}
}
+OutDS = {
Class = FileWriter
+Signals = {
OutSig = { Type = uint32 }
}
}
+GAM = {
Class = IOGAM
+InputSignals = {
}
+OutputSignals = {
}
}
`
uri := "file://signals.marte"
lsp.Documents[uri] = content
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatal(err)
}
lsp.Tree.AddFile("signals.marte", cfg)
// 1. Suggest in InputSignals
// Line 16 (empty line inside InputSignals)
paramsIn := lsp.CompletionParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 16, Character: 8},
}
listIn := lsp.HandleCompletion(paramsIn)
if listIn == nil {
t.Fatal("Expected suggestions in InputSignals")
}
foundIn := false
foundOut := false
for _, item := range listIn.Items {
if item.Label == "InDS:InSig" {
foundIn = true
// Normalize spaces for check
insert := strings.ReplaceAll(item.InsertText, " ", "")
expected := "InSig={DataSource=InDS}"
if !strings.Contains(insert, expected) && !strings.Contains(item.InsertText, "InSig = {") {
// Snippet might differ slightly, but should contain essentials
t.Errorf("InsertText mismatch: %s", item.InsertText)
}
}
if item.Label == "OutDS:OutSig" {
foundOut = true
}
}
if !foundIn {
t.Error("Did not find InDS:InSig")
}
if foundOut {
t.Error("Should not find OutDS:OutSig in InputSignals")
}
// 2. Suggest in OutputSignals
// Line 19
paramsOut := lsp.CompletionParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 19, Character: 8},
}
listOut := lsp.HandleCompletion(paramsOut)
if listOut == nil {
t.Fatal("Expected suggestions in OutputSignals")
}
foundIn = false
foundOut = false
for _, item := range listOut.Items {
if item.Label == "InDS:InSig" {
foundIn = true
}
if item.Label == "OutDS:OutSig" {
foundOut = true
}
}
if foundIn {
t.Error("Should not find InDS:InSig in OutputSignals")
}
if !foundOut {
t.Error("Did not find OutDS:OutSig in OutputSignals")
}
}

74
test/lsp_crash_test.go Normal file
View File

@@ -0,0 +1,74 @@
package integration
import (
"strings"
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/lsp"
"github.com/marte-community/marte-dev-tools/internal/parser"
)
func TestLSPCrashOnUndefinedReference(t *testing.T) {
// Setup
lsp.Tree = index.NewProjectTree()
lsp.Documents = make(map[string]string)
content := `
+App = {
Class = RealTimeApplication
+State = {
Class = RealTimeState
+Thread = {
Class = RealTimeThread
Functions = { UndefinedGAM }
}
}
}
`
uri := "file://crash.marte"
lsp.Documents[uri] = content
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatal(err)
}
lsp.Tree.AddFile("crash.marte", cfg)
lsp.Tree.ResolveReferences()
// Line 7: " Functions = { UndefinedGAM }"
// 12 spaces + "Functions" (9) + " = { " (5) = 26 chars prefix.
// UndefinedGAM starts at 26.
params := lsp.DefinitionParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 7, Character: 27},
}
// This should NOT panic
defer func() {
if r := recover(); r != nil {
t.Errorf("Recovered from panic: %v", r)
}
}()
res := lsp.HandleDefinition(params)
if res != nil {
t.Error("Expected nil for undefined reference definition")
}
// 2. Hover
hParams := lsp.HoverParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 7, Character: 27},
}
hover := lsp.HandleHover(hParams)
if hover == nil {
t.Error("Expected hover for unresolved reference")
} else {
content := hover.Contents.(lsp.MarkupContent).Value
if !strings.Contains(content, "Unresolved") {
t.Errorf("Expected 'Unresolved' in hover, got: %s", content)
}
}
}

View File

@@ -0,0 +1,81 @@
package integration
import (
"strings"
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/lsp"
"github.com/marte-community/marte-dev-tools/internal/parser"
)
func TestHoverDataSourceName(t *testing.T) {
// Setup
lsp.Tree = index.NewProjectTree()
lsp.Documents = make(map[string]string)
content := `
+DS1 = {
Class = FileReader
+Signals = {
Sig1 = { Type = uint32 }
}
}
+GAM1 = {
Class = IOGAM
+InputSignals = {
S1 = {
DataSource = DS1
Alias = Sig1
}
}
}
`
uri := "file://test_ds.marte"
lsp.Documents[uri] = content
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatalf("Parse error: %v", err)
}
lsp.Tree.AddFile("test_ds.marte", cfg)
lsp.Tree.ResolveReferences()
// Test 1: Explicit Signal (Sig1)
// Position: "Sig1" at line 5 (0-based 4)
// Line 4: " Sig1 = { Type = uint32 }"
// Col: 8
params1 := lsp.HoverParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 4, Character: 9},
}
hover1 := lsp.HandleHover(params1)
if hover1 == nil {
t.Fatal("Expected hover for Sig1")
}
content1 := hover1.Contents.(lsp.MarkupContent).Value
// Expectation: explicit signal shows owner datasource
if !strings.Contains(content1, "**DataSource**: `+DS1`") && !strings.Contains(content1, "**DataSource**: `DS1`") {
t.Errorf("Expected DataSource: +DS1 in hover for Sig1, got: %s", content1)
}
// Test 2: Implicit Signal (S1)
// Position: "S1" at line 11 (0-based 10)
params2 := lsp.HoverParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 10, Character: 9},
}
hover2 := lsp.HandleHover(params2)
if hover2 == nil {
t.Fatal("Expected hover for S1")
}
content2 := hover2.Contents.(lsp.MarkupContent).Value
// Expectation: implicit signal shows referenced datasource
if !strings.Contains(content2, "**DataSource**: `DS1`") {
t.Errorf("Expected DataSource: DS1 in hover for S1, got: %s", content2)
}
}

View File

@@ -0,0 +1,75 @@
package integration
import (
"strings"
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/lsp"
"github.com/marte-community/marte-dev-tools/internal/parser"
)
func TestHoverGAMUsage(t *testing.T) {
// Setup
lsp.Tree = index.NewProjectTree()
lsp.Documents = make(map[string]string)
content := `
+DS1 = {
Class = FileReader
+Signals = {
Sig1 = { Type = uint32 }
}
}
+GAM1 = {
Class = IOGAM
+InputSignals = {
S1 = {
DataSource = DS1
Alias = Sig1
}
}
}
+GAM2 = {
Class = IOGAM
+OutputSignals = {
S2 = {
DataSource = DS1
Alias = Sig1
}
}
}
`
uri := "file://test_gam_usage.marte"
lsp.Documents[uri] = content
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatal(err)
}
lsp.Tree.AddFile("test_gam_usage.marte", cfg)
lsp.Tree.ResolveReferences()
// Query hover for Sig1 (Line 5)
// Line 4: Sig1... (0-based)
params := lsp.HoverParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 4, Character: 9},
}
hover := lsp.HandleHover(params)
if hover == nil {
t.Fatal("Expected hover")
}
contentHover := hover.Contents.(lsp.MarkupContent).Value
if !strings.Contains(contentHover, "**Used in GAMs**") {
t.Errorf("Expected 'Used in GAMs' section, got:\n%s", contentHover)
}
if !strings.Contains(contentHover, "- +GAM1") {
t.Error("Expected +GAM1 in usage list")
}
if !strings.Contains(contentHover, "- +GAM2") {
t.Error("Expected +GAM2 in usage list")
}
}

View File

@@ -0,0 +1,89 @@
package integration
import (
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/lsp"
"github.com/marte-community/marte-dev-tools/internal/parser"
"github.com/marte-community/marte-dev-tools/internal/validator"
)
func TestRenameImplicitToDefinition(t *testing.T) {
// Setup
lsp.Tree = index.NewProjectTree()
lsp.Documents = make(map[string]string)
content := `
+DS = {
Class = FileReader
+Signals = {
Sig1 = { Type = uint32 }
}
}
+GAM = {
Class = IOGAM
+InputSignals = {
// Implicit usage
Sig1 = { DataSource = DS }
}
}
`
uri := "file://rename_imp.marte"
lsp.Documents[uri] = content
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatal(err)
}
lsp.Tree.AddFile("rename_imp.marte", cfg)
lsp.Tree.ResolveReferences()
// Run validator to link targets
v := validator.NewValidator(lsp.Tree, ".")
v.ValidateProject()
// Rename Implicit Sig1 (Line 11, 0-based 11)
// Line 11: " Sig1 = { DataSource = DS }"
params := lsp.RenameParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 11, Character: 9},
NewName: "NewSig",
}
edit := lsp.HandleRename(params)
if edit == nil {
t.Fatal("Expected edits")
}
edits := edit.Changes[uri]
// Expect:
// 1. Rename Implicit Sig1 (Line 9) -> NewSig
// 2. Rename Definition Sig1 (Line 4) -> NewSig
if len(edits) != 2 {
t.Errorf("Expected 2 edits, got %d", len(edits))
for _, e := range edits {
t.Logf("Edit at line %d", e.Range.Start.Line)
}
}
foundDef := false
foundImp := false
for _, e := range edits {
if e.Range.Start.Line == 4 {
foundDef = true
}
if e.Range.Start.Line == 11 {
foundImp = true
}
}
if !foundDef {
t.Error("Definition not renamed")
}
if !foundImp {
t.Error("Implicit usage not renamed")
}
}

View File

@@ -0,0 +1,110 @@
package integration
import (
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/lsp"
"github.com/marte-community/marte-dev-tools/internal/parser"
"github.com/marte-community/marte-dev-tools/internal/validator"
)
func TestRenameSignalInGAM(t *testing.T) {
// Setup
lsp.Tree = index.NewProjectTree()
lsp.Documents = make(map[string]string)
content := `
+DS = {
Class = FileReader
+Signals = {
Sig1 = { Type = uint32 }
}
}
+GAM = {
Class = IOGAM
+InputSignals = {
// Implicit match
Sig1 = { DataSource = DS }
// Explicit Alias
S2 = { DataSource = DS Alias = Sig1 }
}
}
`
uri := "file://rename_sig.marte"
lsp.Documents[uri] = content
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatal(err)
}
lsp.Tree.AddFile("rename_sig.marte", cfg)
lsp.Tree.ResolveReferences()
// Run validator to populate Targets
v := validator.NewValidator(lsp.Tree, ".")
v.ValidateProject()
// Rename DS.Sig1 to NewSig
// Sig1 is at Line 5.
// Line 0: empty
// Line 1: +DS
// Line 2: Class
// Line 3: +Signals
// Line 4: Sig1
params := lsp.RenameParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 4, Character: 9}, // Sig1
NewName: "NewSig",
}
edit := lsp.HandleRename(params)
if edit == nil {
t.Fatal("Expected edits")
}
edits := edit.Changes[uri]
// Expect:
// 1. Definition of Sig1 in DS (Line 5) -> NewSig
// 2. Definition of Sig1 in GAM (Line 10) -> NewSig (Implicit match)
// 3. Alias reference in S2 (Line 12) -> NewSig
// Line 10: Sig1 = ... (0-based 9)
// Line 12: S2 = ... Alias = Sig1 (0-based 11)
expectedCount := 3
if len(edits) != expectedCount {
t.Errorf("Expected %d edits, got %d", expectedCount, len(edits))
for _, e := range edits {
t.Logf("Edit: %s at %d", e.NewText, e.Range.Start.Line)
}
}
// Check Implicit Signal Rename
foundImplicit := false
for _, e := range edits {
if e.Range.Start.Line == 11 {
if e.NewText == "NewSig" {
foundImplicit = true
}
}
}
if !foundImplicit {
t.Error("Did not find implicit signal rename")
}
// Check Alias Rename
foundAlias := false
for _, e := range edits {
if e.Range.Start.Line == 13 {
// Alias = Sig1. Range should cover Sig1.
if e.NewText == "NewSig" {
foundAlias = true
}
}
}
if !foundAlias {
t.Error("Did not find alias reference rename")
}
}

92
test/lsp_rename_test.go Normal file
View File

@@ -0,0 +1,92 @@
package integration
import (
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/lsp"
"github.com/marte-community/marte-dev-tools/internal/parser"
)
func TestHandleRename(t *testing.T) {
// Setup
lsp.Tree = index.NewProjectTree()
lsp.Documents = make(map[string]string)
content := `
#package Some
+MyNode = {
Class = Type
}
+Consumer = {
Link = MyNode
PkgLink = Some.MyNode
}
`
uri := "file://rename.marte"
lsp.Documents[uri] = content
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatal(err)
}
lsp.Tree.AddFile("rename.marte", cfg)
lsp.Tree.ResolveReferences()
// Rename +MyNode to NewNode
// +MyNode is at Line 2 (after #package)
// Line 0: empty
// Line 1: #package
// Line 2: +MyNode
params := lsp.RenameParams{
TextDocument: lsp.TextDocumentIdentifier{URI: uri},
Position: lsp.Position{Line: 2, Character: 4}, // +MyNode
NewName: "NewNode",
}
edit := lsp.HandleRename(params)
if edit == nil {
t.Fatal("Expected edits")
}
edits := edit.Changes[uri]
if len(edits) != 3 {
t.Errorf("Expected 3 edits (Def, Link, PkgLink), got %d", len(edits))
}
// Verify Definition change (+MyNode -> +NewNode)
foundDef := false
for _, e := range edits {
if e.NewText == "+NewNode" {
foundDef = true
if e.Range.Start.Line != 2 {
t.Errorf("Definition edit line wrong: %d", e.Range.Start.Line)
}
}
}
if !foundDef {
t.Error("Did not find definition edit +NewNode")
}
// Verify Link change (MyNode -> NewNode)
foundLink := false
for _, e := range edits {
if e.NewText == "NewNode" && e.Range.Start.Line == 6 { // Link = MyNode
foundLink = true
}
}
if !foundLink {
t.Error("Did not find Link edit")
}
// Verify PkgLink change (Some.MyNode -> Some.NewNode)
foundPkg := false
for _, e := range edits {
if e.NewText == "NewNode" && e.Range.Start.Line == 7 { // PkgLink = Some.MyNode
foundPkg = true
}
}
if !foundPkg {
t.Error("Did not find PkgLink edit")
}
}

View File

@@ -0,0 +1,77 @@
package integration
import (
"bytes"
"strings"
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/lsp"
"github.com/marte-community/marte-dev-tools/internal/schema"
)
func TestLSPValidationThreading(t *testing.T) {
// Setup
lsp.Tree = index.NewProjectTree()
lsp.Documents = make(map[string]string)
lsp.ProjectRoot = "."
lsp.GlobalSchema = schema.NewSchema() // Empty schema but not nil
// Capture Output
var buf bytes.Buffer
lsp.Output = &buf
content := `
+Data = {
Class = ReferenceContainer
+SharedDS = {
Class = GAMDataSource
#meta = {
direction = "INOUT"
multithreaded = false
}
Signals = {
Sig1 = { Type = uint32 }
}
}
}
+GAM1 = { Class = IOGAM InputSignals = { Sig1 = { DataSource = SharedDS Type = uint32 } } }
+GAM2 = { Class = IOGAM OutputSignals = { Sig1 = { DataSource = SharedDS Type = uint32 } } }
+App = {
Class = RealTimeApplication
+States = {
Class = ReferenceContainer
+State1 = {
Class = RealTimeState
+Thread1 = { Class = RealTimeThread Functions = { GAM1 } }
+Thread2 = { Class = RealTimeThread Functions = { GAM2 } }
}
}
}
`
uri := "file://threading.marte"
// Call HandleDidOpen directly
params := lsp.DidOpenTextDocumentParams{
TextDocument: lsp.TextDocumentItem{
URI: uri,
Text: content,
},
}
lsp.HandleDidOpen(params)
// Check output
output := buf.String()
// We look for publishDiagnostics notification
if !strings.Contains(output, "textDocument/publishDiagnostics") {
t.Fatal("Did not receive publishDiagnostics")
}
// We look for the specific error message
expectedError := "DataSource '+SharedDS' is not multithreaded but used in multiple threads"
if !strings.Contains(output, expectedError) {
t.Errorf("Expected error '%s' not found in LSP output. Output:\n%s", expectedError, output)
}
}

View File

@@ -0,0 +1,124 @@
package integration
import (
"strings"
"testing"
"github.com/marte-community/marte-dev-tools/internal/index"
"github.com/marte-community/marte-dev-tools/internal/parser"
"github.com/marte-community/marte-dev-tools/internal/validator"
)
func TestDataSourceThreadingValidation(t *testing.T) {
content := `
+Data = {
Class = ReferenceContainer
+SharedDS = {
Class = GAMDataSource
#meta = {
direction = "INOUT"
multithreaded = false
}
Signals = {
Sig1 = { Type = uint32 }
}
}
+MultiDS = {
Class = GAMDataSource
#meta = {
direction = "INOUT"
multithreaded = true
}
Signals = {
Sig1 = { Type = uint32 }
}
}
}
+GAM1 = {
Class = IOGAM
InputSignals = {
Sig1 = { DataSource = SharedDS Type = uint32 }
}
}
+GAM2 = {
Class = IOGAM
OutputSignals = {
Sig1 = { DataSource = SharedDS Type = uint32 }
}
}
+GAM3 = {
Class = IOGAM
InputSignals = {
Sig1 = { DataSource = MultiDS Type = uint32 }
}
}
+GAM4 = {
Class = IOGAM
OutputSignals = {
Sig1 = { DataSource = MultiDS Type = uint32 }
}
}
+App = {
Class = RealTimeApplication
+States = {
Class = ReferenceContainer
+State1 = {
Class = RealTimeState
+Thread1 = {
Class = RealTimeThread
Functions = { GAM1 }
}
+Thread2 = {
Class = RealTimeThread
Functions = { GAM2 }
}
}
+State2 = {
Class = RealTimeState
+Thread1 = {
Class = RealTimeThread
Functions = { GAM3 }
}
+Thread2 = {
Class = RealTimeThread
Functions = { GAM4 }
}
}
}
}
`
pt := index.NewProjectTree()
p := parser.NewParser(content)
cfg, err := p.Parse()
if err != nil {
t.Fatal(err)
}
pt.AddFile("main.marte", cfg)
// Since we don't load schema here (empty path), it won't validate classes via CUE,
// but CheckDataSourceThreading relies on parsing logic, not CUE schema unification.
// So it should work.
v := validator.NewValidator(pt, "")
v.ValidateProject()
foundError := false
for _, d := range v.Diagnostics {
if strings.Contains(d.Message, "not multithreaded but used in multiple threads") {
if strings.Contains(d.Message, "SharedDS") {
foundError = true
}
if strings.Contains(d.Message, "MultiDS") {
t.Error("Unexpected threading error for MultiDS")
}
}
}
if !foundError {
t.Error("Expected threading error for SharedDS")
// Debug
for _, d := range v.Diagnostics {
t.Logf("Diag: %s", d.Message)
}
}
}

View File

@@ -23,6 +23,7 @@ func TestGAMSignalLinking(t *testing.T) {
+MyGAM = {
Class = IOGAM
//! ignore(unused)
InputSignals = {
MySig = {
DataSource = MyDS

View File

@@ -107,7 +107,11 @@ func TestHierarchicalPackageMerge(t *testing.T) {
}
// We can also inspect the tree to verify FieldX is there (optional, but good for confidence)
baseNode := idx.Root.Children["Base"]
projNode := idx.Root.Children["Proj"]
if projNode == nil {
t.Fatal("Proj node not found")
}
baseNode := projNode.Children["Base"]
if baseNode == nil {
t.Fatal("Base node not found")
}