fix: address all 9 findings from final calibration code review

- calibration.js: fix baseSignalName('[0]') parity with Go/C++ (>= 0 not > 0)
- calibration.test.js: add assertions for '[0]' edge case in two existing tests
- app.js: remove stale typeof guard around refreshVScaleMenu (always defined)
- app.js: call refreshTrigThresholdField on trig-signal change (both assignment sites)
- index.html: drop maxlength='16' on unit input; normaliseCal is the sole enforcer
- configcheck/main.go: delete dead nextOneOf function (no callers)
- hub_calibration_test.go: delete orphaned waitBroadcast comment (function never existed)
- calibration.go: correct arrayIndexSuffix comment to document known Go/C++ difference
- Docs/StreamHub-API.md: add calibration entry count and unit byte limits to §5 table
- spec: fix configReloaded missing path field, '16 chars'→'16 UTF-8 bytes', StreamString→char[], chain scenario→configcheck program, four→five new frames

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

This commit is contained in:

Martino Ferrari

2026-08-17 07:57:28 +02:00

co-authored by

Claude Sonnet 4.6

parent 42f5a726af

commit 1f8592f854

10 changed files with 238 additions and 54 deletions

Docs/StreamHub-API.md

View File

@@ -392,3 +392,5 @@ written by either hub loads in the other.
 | UDPS source sessions | 32 |
 | Max received WS payload | 64 KiB |
 | Max sent WS payload | 4 MiB |
 | Calibration entries | 256 (C++ hub, `kMaxCalibration`); unbounded (Go hub) |
 | Calibration unit override | 16 UTF-8 bytes |